test: Use byte literals for Python3 compatibility #31030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the stream is opened in binary mode. On Python3 that requires the replace to also operate in binary mode.
|
Cool! @swift-ci smoke test and merge |
|
@swift-ci smoke test Linux |
|
@CodaFi the linux tests failed but I don't know how this caused it. The line related to this test says: Suggestions? |
|
@swift-ci please test Windows platform |
|
It’s not your failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the stream is opened in binary mode. On Python3 that requires the
replaceto also operate in binary mode.