Fix crash with invalid private @inlinable function #31060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
CodaFi
reviewed
Apr 16, 2020
lib/AST/DeclContext.cpp
Outdated
| ResilienceExpansion DeclContext::getResilienceExpansion() const { | ||
| auto fragileKind = getFragileFunctionKind(); | ||
| switch (fragileKind.kind) { | ||
| case FragileFunctionKind::Transparent: |
There was a problem hiding this comment.
Nit: LLVM-style switch-cases please.
There was a problem hiding this comment.
Oops, that was an accident.
…ntext We had some duplicated logic between getResilienceExpansion() and getFragileFunctionKind(). Clean this up by moving the latter into AST, and re-implementing the former in terms of the latter. This also fixes a crash in at least one case where these two implementations had previously diverged. Fixes <rdar://problem/60605117>.
slavapestov
force-pushed
the
fix-fragile-function-kind-crash
branch
from
a19b6df to
e2349bd
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
@millenomi Any ideas? |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some duplicated logic between getResilienceExpansion() and getFragileFunctionKind(). Clean this up by moving the latter into AST, and re-implementing the former in terms of the latter.
This also fixes a crash in at least one case where these two implementations had previously diverged.
Fixes rdar://problem/60605117.