Skip to content

build: remove the last unversioned python reference #31085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

compnerd
Copy link
Member

Explicitly use versioned python interpreters for tools. This replaces
the last unversioned reference.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Explicitly use versioned python interpreters for tools.  This replaces
the last unversioned reference.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test android platform

@compnerd
Copy link
Member Author

CC: @drexin @RLovelett @drodriguez

@drodriguez
Copy link
Contributor

Give me until tonight to install Python 3 in the build machines. I will merge this when I am done.

Those two, however, I don't think they get executed in CI, so unless CMake fails trying to find values, it might interpolate to nothing, but since CI should not execute those lines, it might be fine.

@swift-ci please test android platform

Ha ha. I wish that was working.

@drodriguez
Copy link
Contributor

Seems to work OK, and I check python3 is in the path, so I hope CMake is finding the right one.

There was a problem with line-directive in the file stdlib/private/SwiftPrivateLibcExtras/Subprocess.swift, where a appears in a comment. I changed it to the ASCII ' and no problem. If the problem appears in CI, I will know what to change.

Thanks for moving Python 3 forward!

@drodriguez drodriguez merged commit 6995449 into swiftlang:master Apr 17, 2020
@compnerd compnerd deleted the android-python-3 branch April 17, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants