-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[AutoDiff] differentiation benchmarks #31108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please benchmark |
@swift-ci Please benchmark |
@swift-ci Please benchmark |
1 similar comment
@swift-ci Please benchmark |
Oh no, this is failing with a non-informative error: I have only tested this on Linux. Maybe it breaks on macos for some reason. I'll build it on my mac and see if I can get it to work on that. |
@@ -36,4 +36,5 @@ add_swift_target_library(swift_Differentiation ${SWIFT_STDLIB_LIBRARY_BUILD_TYPE | |||
${SWIFT_STANDARD_LIBRARY_SWIFT_FLAGS} | |||
-parse-stdlib | |||
LINK_FLAGS "${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}" | |||
DARWIN_INSTALL_NAME_DIR "@rpath" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think missing this caused my rpath errors as well!
I found a fix that may get the differentiation benchmark working on macos. But I'm a bit unsure about it, so I'll open a separate PR to discuss the fix. I've converted this PR to a draft in the meantime. |
@swift-ci please benchmark |
1 similar comment
@swift-ci please benchmark |
Performance: -O
Code size: -O
Performance: -Osize
Code size: -OsizePerformance: -Onone
Code size: -swiftlibs
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
Note to self: Add benchmarks for |
Adds some differentiation benchmarks.
I have tagged them
.regression
because I don't yet have any specific codegen/optimization operations in mind to test. When we start looking more closely at the performance of differentiation and identifying specific operations that are important for the performance, we can add.validation
benchmarks.@eeckstein could you check if I've used the framework correctly? (Or redirect me to someone else who can review this?)