[OSLogOptimization] Improve SIL-level diagnostics generated for the os log APIs. #31120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os log APIs, based on the fact that there is already a Sema check for enforcing the user model. Suppress the errors generated by for the _globalStringTablePointerBuiltin when the OSLogOptimization pass emits diagnostics. This elimiantes the cryptic error that always accompanies the diagnostics emitted by the OSLogOptimization pass.
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci please smoke test Linux Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there is already a Sema check for enforcing the user model, the SIL-level diagnostics can be a bit more targeted.
Also, suppress the errors generated by for the _globalStringTablePointerBuiltin when the OSLogOptimization pass emits diagnostics. This eliminates the cryptic error that always accompanies the diagnostics emitted by the OSLogOptimization pass.