Skip to content

[Coverage] Handle non-local exits out of DoStmt's properly #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vedantk
Copy link
Contributor

@vedantk vedantk commented Jun 21, 2016

What's in this pull request?

This is a code coverage fix for swift 3.0.

Resolved bug number: (SR-1850)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

First, assign counter expressions to the DoStmt and its body. Next,
fix the count associated to the DoStmt when handling a non-local exit.

This fixes SR-1850.

(cherry picked from commit 348b78a)

First, assign counter expressions to the DoStmt and its body. Next,
fix the count associated to the DoStmt when handling a non-local exit.

This fixes SR-1850.

(cherry picked from commit 348b78a)
@vedantk
Copy link
Contributor Author

vedantk commented Jun 22, 2016

@swift-ci Please smoke test OS X platform

@tkremenek tkremenek merged commit 8bd98f2 into swiftlang:swift-3.0-preview-2-branch Jun 23, 2016
@vedantk vedantk deleted the swift-3.0-preview-2-branch branch January 31, 2018 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants