[SR-12626] Fix crash when non WritableKeyPath to a set subscript assign #31140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPAlmeida
force-pushed
the
SR-12425-crash-dynamic-member-key-path
branch
from
bbf0432 to
655bc92
Compare
…y path dynamicMemberLookup
LucianoPAlmeida
force-pushed
the
SR-12425-crash-dynamic-member-key-path
branch
from
655bc92 to
4dfbf6f
Compare
LucianoPAlmeida
force-pushed
the
SR-12425-crash-dynamic-member-key-path
branch
from
4dfbf6f to
ab81236
Compare
xedin
approved these changes
Apr 20, 2020
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
Thanks @xedin @hamishknight :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes SR-12626 where applying a non-WritableKeyPath to a set subscript crashes the compiler.
Also, partially fixes the SR-12425, fixing the crash, but diagnostics have to be improved. So just added the test cases
cc @xedin @hamishknight :)
Resolves SR-12626.