Skip to content

[Frontend][NFC] Formalize isModuleExternallyConsumed #31145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2020
Merged

[Frontend][NFC] Formalize isModuleExternallyConsumed #31145

merged 2 commits into from
Apr 20, 2020

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Apr 20, 2020

Yank this parameter and document the historical scope creep of this value.

@CodaFi CodaFi requested a review from davidungar April 20, 2020 00:23
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 20, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e2b7c9c630f56293bd63109f42c4437d0b24ea68

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 20, 2020

@swift-ci test Linux

davidungar
davidungar approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@davidungar davidungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, especially the "why" comments!

CodaFi added 2 commits April 19, 2020 21:45
@CodaFi
[Gardening] Const-qualify CompilerInstance::getInvocation()
7fb81ea
@CodaFi
[NFC] Formalize isModuleExternallyConsumed
37f016b 
Yank this parameter and document the historical scope creep of this value.
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 20, 2020

@swift-ci test

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 20, 2020

@swift-ci test Windows

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 20, 2020

⛵

@CodaFi CodaFi merged commit ad967dd into swiftlang:master Apr 20, 2020
@CodaFi CodaFi deleted the all-bran branch April 20, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidungar davidungar davidungar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @swift-ci @davidungar