Fixes info about internal _FixedArray16 in StandardLibraryProgrammersManual.md #31150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
Builder died @swift-ci smoke test macOS |
Hope that's not me. |
|
@valeriyvan Goodness, I hope not. It's Jenkins. It's always Jenkins... |
|
⛵ |
xwu
reviewed
Apr 23, 2020
| @@ -220,7 +220,7 @@ The standard library cannot import the Darwin module (much less an ICU module), | |||
|
|
|||
| #### `_FixedArray` | |||
|
|
|||
| The standard library has internal fixed size arrays of some limited sizes. This provides fast random access into contiguous (usually stack-allocated) memory. These are metaprogrammed based on size, so if you need a new size not currently defined, add it to the `sizes` gyb variable. See [FixedArray.swift.gyb](https://github.com/apple/swift/blob/master/stdlib/public/core/FixedArray.swift.gyb) for implementation. | |||
| The standard library has internal array of fixed size 16. This provides fast random access into contiguous (usually stack-allocated) memory. See [FixedArray.swift](https://github.com/apple/swift/blob/master/stdlib/public/core/FixedArray.swift) for implementation. | |||
There was a problem hiding this comment.
Suggestion: "has an internal array type of fixed size 16."
| @@ -220,7 +220,7 @@ The standard library cannot import the Darwin module (much less an ICU module), | |||
|
|
|||
| #### `_FixedArray` | |||
There was a problem hiding this comment.
Suggestion: update heading to _FixedArray16.
|
@xwu, should I make new PR for this? |
|
That would be lovely; no hurry of course. |
valeriyvan
added a commit
to valeriyvan/swift
that referenced
this pull request
Apr 24, 2020
Suggestion of @xwu in PR swiftlang#31150 after it was already merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes info about internal _FixedArray16 in StandardLibraryProgrammersManual.md