[CS] A couple of cleanups #31155
Merged
[CS] A couple of cleanups #31155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only caller was `contractEdges`, which would only call it with constraints from either the active or inactive list. The implementation can therefore be replaced by `ConstraintSystem::retireConstraint`, and `removeGeneratedConstraint` can also be removed.
Retired constraints get added back to the inactive list when a scope rolls back, and generated constraints then get removed. So adding a constraint as both is unnecessary. Also assert that `addNewFailingConstraint` doesn't get called with an active constraint.
The fully-boundness refers to the system rather than the bindings.
|
@swift-ci please test |
xedin
approved these changes
Apr 20, 2020
|
@swift-ci please test source compatibility |
|
@swift-ci please test macOS |
|
@swift-ci please test source compatibility |
|
Debug source compat failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstraintGraph::removeEdge, usingretireConstraintinstead.