Re-add the optional overload for atomic ptr swaps #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you gyb a few tests in |
CodaFi
changed the title
|
@gribozavr Sorry that took a bit. Had to re-run stdlib-gen on my end. |
| var origP3 = IntPtr(bitPattern: 0x30303030)! | ||
| var origP1 : IntPtr${optionality} = IntPtr(bitPattern: 0x10101010)! | ||
| var origP2 : IntPtr${optionality} = IntPtr(bitPattern: 0x20202020)! | ||
| var origP3 : IntPtr${optionality} = IntPtr(bitPattern: 0x30303030)! |
There was a problem hiding this comment.
There should not be a space before the colon.
|
@gribozavr Mind running CI again? |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
@gribozavr Noticed the optional overload for
_stdlib_atomicCompareExchangeStrongPtrwas missing. Let's gyb it back in.Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.