Skip to content

AST: Fast path for matching can. signatures in requirementsNotSatisfiedBy #31214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2020
Merged

AST: Fast path for matching can. signatures in requirementsNotSatisfiedBy #31214

merged 2 commits into from
Apr 23, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Apr 22, 2020 •
edited
Loading

Let's indeed isolate this change (suggested in #30700, extracted from #30712).

@CodaFi If you may

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis requested a review from CodaFi April 22, 2020 21:13
@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 23, 2020 •
edited
Loading

I have amended differenceAndStoreConditionalRequirements() to never allocate a copy on the AST context when there are no conditional requirements.

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis merged commit e659ecf into swiftlang:master Apr 23, 2020
@AnthonyLatsis AnthonyLatsis deleted the req-sat-by-fast branch April 23, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @CodaFi