Refactor checkGenericArguments() and related code #31226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CodaFi The last commit re-indents part of TypeChecker.h; ignore it for the purposes of the review. |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
Builder died @swift-ci test source compatibility release |
CodaFi
approved these changes
Apr 23, 2020
…anceInModule Calling TypeChecker::conformsToProtocol() with SkipConditionalRequirements and an invalid SourceLoc() is now the same as calling ModuleDecl::lookupConformance(), so we can replace all usages of TypeChecker::LookUpConformance with LookUpConformanceInModule.
…rguments() All callers were just doing module lookups.
…g autodiff attributes
All callers can trivially be refactored to use ModuleDecl::lookupConformance() instead. Since this was the last flag in ConformanceCheckOptions, we can remove that, too.
slavapestov
force-pushed
the
check-generic-arguments-refactoring
branch
from
c77f2e8 to
796fd46
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
TypeChecker::conformsToProtocol()no longer uses the DeclContext to record dependencies, we can make a few simplifications:ModuleDecl::lookupConformance()insteadConformanceCheckFlagsnow that the last remaining flag is gonecheckGenericArguments()a littleThe last remaining usage of the DeclContext is a
mapTypeIntoContext()call incheckGenericArguments().The next step is to refactor
checkGenericArguments()andconformsToProtocol()to take a module instead of a DeclContext.After that, I would like to split off the diagnostics and listener logic from
checkGenericArguments()into a new method, and move the lower-level semantic query from Sema to AST.