[IDE][AST] Handle frameworks with traditional overlays where the underlying module declares cross imports in sourcekit #31227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Failure seems unrelated: |
|
@swift-ci please test OS X Platform |
|
Build failed |
…rlying module declares cross imports in sourcekit. We weren't handling this case, so their generated interfaces / doc info wouldn't include symbols from the cross-import overlays, and we wouldn't map the underscored cross-import overlay name back to the declaring framework's name in cusor-info, completion results or when indexing. Resolves rdar://problem/62138551
nathawes
force-pushed
the
cross-import-tooling-fixes
branch
from
ab4149e to
b7ac8f8
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Windows Platform |
|
@swift-ci please test windows |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Windows Platform |
akyrtzi
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't handling this case, so their generated interfaces / doc info wouldn't include symbols from the cross-import overlays, and we wouldn't map the underscored cross-import overlay name back to the declaring framework's name in cusor-info, completion results or when indexing.
Resolves rdar://problem/62138551