Skip to content

[5.3][Parse] Don't drop parsed error types in where clause from AST #31258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

[5.3][Parse] Don't drop parsed error types in where clause from AST #31258

merged 1 commit into from
Apr 24, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 24, 2020 •
edited
Loading

Cherry-pick of #31238 into release/5.3 reviewed by @nathawes

rdar://problem/61911134

@rintaro
[Parse] Don't drop parsed error types in where clause from AST
ab8b7fe 
Code completion requires the source range of the 'where' clause to
correctly lookup member of types in where clause.

rdar://problem/61911134
(cherry picked from commit 62d8eed)
@rintaro
Copy link
Member Author

rintaro commented Apr 24, 2020

@swift-ci Please test

@rintaro rintaro added the r5.3 label Apr 24, 2020
@rintaro rintaro requested a review from akyrtzi April 24, 2020 02:35
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ab8b7fe

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ab8b7fe

@hamishknight
Copy link
Contributor

@swift-ci please test

@rintaro rintaro merged commit 9560a76 into swiftlang:release/5.3 Apr 24, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rintaro @swift-ci @hamishknight @akyrtzi @AnthonyLatsis