Skip to content

[AutoDiff] fix tests to pass on tensorflow branch #31264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2020
Merged

[AutoDiff] fix tests to pass on tensorflow branch #31264

merged 2 commits into from
Apr 24, 2020

Conversation

marcrasi
Copy link

These tests needed some adjustment to pass on both the master and tensorflow branches.

  • Generic signatures on the branches have Numeric and Differentiable in different orders, so I fixed this using a NumericDifferentiable protocol that combines them.
  • The branches have a different mangled name for Differentiable so I added some wildcards to sil names involving Differentiable.
  • SR-12641 does not crash on tensorflow.

@marcrasi marcrasi requested a review from dan-zheng April 24, 2020 04:30
@marcrasi
Copy link
Author

@swift-ci please test

dan-zheng
dan-zheng approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(TF-1155 should eliminate mangled name differences!)

@marcrasi marcrasi merged commit 207958c into swiftlang:master Apr 24, 2020
@marcrasi marcrasi deleted the fix-ad-test-tf branch April 24, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcrasi @dan-zheng