Update Devirtualizer's analysis invalidation #31284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castValueToABICompatibleType can change CFG, Devirtualizer uses this api but doesn't check if it modified the cfg
|
|
atrick
approved these changes
Apr 27, 2020
|
@swift-ci smoke test |
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Apr 27, 2020
This is cherry-pick of swiftlang#31284 castValueToABICompatibleType can change CFG, Devirtualizer uses this api but doesn't check if it modified the cfg
meg-gupta
added a commit
that referenced
this pull request
Apr 29, 2020
This is cherry-pick of #31284 castValueToABICompatibleType can change CFG, Devirtualizer uses this api but doesn't check if it modified the cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
castValueToABICompatibleTypecan change CFG, Devirtualizer uses this api but doesn't check if it modified the cfg. With this, Devirtualizer checks is cfg changed, and invalidates accordingly.