Skip to content

[5.3] AST: Rename getFullName -> getName on ValueDecl & MissingMemberDecl #31300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2020
Merged

[5.3] AST: Rename getFullName -> getName on ValueDecl & MissingMemberDecl #31300

merged 1 commit into from
Apr 29, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

Cherry-pick #31224

AnthonyLatsis added a commit to AnthonyLatsis/llvm-project that referenced this pull request Apr 24, 2020
@AnthonyLatsis
[5.3][Swift] AST: Rename getFullName -> getName for swiftlang/swift#3…
89df45d 
…1300
@AnthonyLatsis AnthonyLatsis mentioned this pull request Apr 24, 2020
Merged
@AnthonyLatsis
Copy link
Collaborator Author

swiftlang/llvm-project#1120

@swift-ci please test

@AnthonyLatsis AnthonyLatsis requested a review from jckarter April 25, 2020 02:32
@jckarter
Copy link
Contributor

Thanks @AnthonyLatsis! Let me coordinate with our build managers to get this into the 5.3 branch.

airspeedswift
airspeedswift approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@airspeedswift airspeedswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking over to 5.3. Also thanks for adding a link to the original on master. One minor ask, can you summarize what the PR does on follow-up PRs like #31224? That way it isn't necessary to trace back to what it's following up and deduce.

@AnthonyLatsis
Copy link
Collaborator Author

One minor ask, can you summarize what the PR does on follow-up PRs like #31224?

Sure, done!

@jckarter, could you handle the merging between this and then?

@jckarter
Copy link
Contributor

Sorry for the slow reaction, looks like a conflict crept in. Would you be able to clean that up?

@AnthonyLatsis
Copy link
Collaborator Author

Oops, give me a sec.

@AnthonyLatsis AnthonyLatsis force-pushed the rename-getfullname-5.3 branch from e58c557 to 0bd0a29 Compare April 29, 2020 09:38
@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 29, 2020 •
edited
Loading

swiftlang/llvm-project#1120

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e58c55751501c834e1adbe75ab40a4d942325872

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e58c55751501c834e1adbe75ab40a4d942325872

@jckarter jckarter merged commit edafa4d into swiftlang:release/5.3 Apr 29, 2020
jckarter added a commit to swiftlang/llvm-project that referenced this pull request Apr 29, 2020
@jckarter
Merge pull request #1120 from AnthonyLatsis/rename-getfullname-lldb-5.3
b1d2b47 
[5.3][Swift] AST: Rename getFullName -> getName for swiftlang/swift#31300
@jckarter
Copy link
Contributor

Thanks for seeing this through @AnthonyLatsis!

@AnthonyLatsis AnthonyLatsis deleted the rename-getfullname-5.3 branch April 29, 2020 16:28
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

@jckarter jckarter Awaiting requested review from jckarter

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnthonyLatsis @jckarter @swift-ci @airspeedswift