[CS] Connect closure to referenced vars #31304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were only connecting a closure constraint to type variables from param decls that it referenced. This worked fine up until we started type-checking for-in statements entirely in the constraint system, meaning that closures can now reference type variables from the element pattern. Tweak the collection logic to consider vars too. Resolves rdar://62339835
hamishknight
force-pushed
the
connect-closure-to-vars
branch
from
c7ea7bf to
2070b2c
Compare
xedin
approved these changes
Apr 25, 2020
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only connecting a closure constraint to type variables from param decls that it referenced. This worked fine up until we started type-checking for-in statements entirely in the constraint system, meaning that closures can now reference type variables from the element pattern.
Tweak the collection logic to consider vars too.
Resolves rdar://62339835