[CodeCompletion] Prioritize type matching overload for unresovled member #31307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
For exmaple:
func foo(_: Int, _: IntOption)
func foo(_: Float, _: FloatOption)
foo(intVal, .<HERE>)
Previously code completion suggests static member from 'IntOption' and
'FloatOption' without any prioritization. Prioritize members from
'IntOption' because the user probably wants to input them.
In such cases, 'CodeCompletionExpr' at the cursor position is
pre-typechecked to 'IntOption'. So mark results with matching type with
'ExprSpecific'.
rdar://problem/62121221
rintaro
force-pushed
the
ide-completion-rdar62121221
branch
from
b92d0b5 to
e947512
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
benlangmuir
reviewed
Apr 27, 2020
| /// fooo(.<HERE>) | ||
| /// Prefer '.foo' and '.bar' over '.some' and '.none'. | ||
| idealTy = idealTy->lookThroughAllOptionalTypes(); | ||
| return idealTy->isEqual(Ty); |
There was a problem hiding this comment.
Why isEqual instead of isConvertible?
There was a problem hiding this comment.
Returning convertible types by static member is pretty uncommon, I guess.
class Derived: Base { ... }
extension Base {
static func createSub() -> Derived { ... }
}I just didn't want to check them all by relatively heavy isConvertible() just for prioritization. But if you think it's worth it, I'm happy to do it.
There was a problem hiding this comment.
It's fine, just making sure I understand.
benlangmuir
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For exmaple:
Previously, code completion suggests static member from
IntOptionandFloatOptionwithout any prioritization. Prioritize members fromIntOptionbecause the user probably wants to input them.In such cases,
CodeCompletionExprat the cursor position is pre-typehcecked toIntOption. So mark results with matching type withExprSpecific.rdar://problem/62121221