[CodeCompletion] Don't show protocol extension only members in override #31316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Apr 27, 2020
Protocol extension only members are not customization point. Code completion should not suggest them in override/conformance completion. rdar://problem/53591636
rintaro
force-pushed
the
ide-completion-protocolext-rdar53591636
branch
from
57d3545 to
ab7ba4c
Compare
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Apr 27, 2020
|
@swift-ci Please smoke test macOS |
3 similar comments
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol extension only members are not customization points. Code completion should not suggest them in override/conformance completion.
rdar://problem/53591636