Enhance Scudo test to tolerate GWP-Asan. #31335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
When LLVM was updated to a new enough release to have GWP-Asan, we started getting probabilistic test failures, as the double-free would sometimes be caught by GWP-Asan (odds are about 1/5000). We should tolerate either output.
Lukasa
force-pushed
the
cb-gwp-asan-and-scudo
branch
from
ff8e937 to
43bf0e2
Compare
|
@swift-ci please smoke test |
Lukasa
force-pushed
the
cb-gwp-asan-and-scudo
branch
2 times, most recently
from
8827dc3 to
43bf0e2
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
Thanks @Lukasa |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LLVM was updated to a new enough release to have GWP-Asan, we
started getting probabilistic test failures, as the double-free would
sometimes be caught by GWP-Asan (odds are about 1/5000).
We should tolerate either output.
In some sense it's hard to validate that this change actually works, but I feel confident we'll know after a week or so.