Skip to content

[Gardening] Remove Outdated Advice About -### and -incremental #31353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Apr 27, 2020

Using -### is insufficient to discover the entire set of frontend jobs
needed to satisfy a given incremental compilation session because of the
presence of additional waves of recompilation. More concretely, any
additional compilation jobs whose queueing behavior depends on the set
of jobs reported by -### are, by definition, hidden from -###.

Note that it is also not possible to run the incremental build to
a fixpoint by iteratively executing said frontend jobs and re-running
the driver with -### because the build record is never updated to
account for the jobs executed by an external system.

Using -### is insufficient to discover the entire set of frontend jobs
needed to satisfy a given incremental compilation session because of the
presence of additional waves of recompilation. More concretely, any
additional compilation jobs whose queueing behavior depends on the set
of jobs reported by -### are, by definition, hidden from -###.

Note that it is also *not* possible to run the incremental build to
a fixpoint by iteratively executing said frontend jobs and re-running
the driver with -### because the build record is never updated to
account for the jobs executed by an external system.
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 27, 2020

@swift-ci smoke test

@davidungar davidungar self-requested a review April 27, 2020 23:44
Copy link
Contributor

@davidungar davidungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 28, 2020

@swift-ci smoke test and merge

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 28, 2020

@swift-ci smoke test

2 similar comments
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 28, 2020

@swift-ci smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 28, 2020

@swift-ci smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 28, 2020

@swift-ci smoke test macOS

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 29, 2020

@swift-ci clean smoke test macOS

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 29, 2020

@CodaFi CodaFi merged commit c51b86e into swiftlang:master Apr 29, 2020
@CodaFi CodaFi deleted the incremental-advisor branch April 29, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants