Object formats #3137
Merged
Object formats #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
referenced
this pull request
Jun 22, 2016
gold only supports ELF. This adds two new helper functions (is_windows_based_sdk and is_elfish_sdk) to ensure that we dont try to use gold on non-ELF targets. This comes up when trying to setup cross-compilation for the standard library for Windows. The ELF check is implemented as the negation of Darwin (which uses MachO) and Windows (which uses COFF). The reason for this is that there are additional targets which also use ELF. Rather than enumerating the larger set, enumerate the smaller set (windows) and use the negation.
| @@ -103,8 +102,7 @@ add_swift_library(section_magic_end OBJECT_LIBRARY IS_STDLIB IS_STDLIB_CORE | |||
|
|
|||
| set(object_target_list) | |||
| foreach(sdk ${SWIFT_CONFIGURED_SDKS}) | |||
| is_elfish_sdk("${sdk}" IS_ELFISH) | |||
| if(IS_ELFISH) | |||
| if("${SWIFT_SDK_${sdk}_OBJECT_FORMAT}" STREQUAL "ELF") | |||
There was a problem hiding this comment.
Why not just loop ${ELFISH_SDKS}?
There was a problem hiding this comment.
Because that would be smart and why I had put EFLISH_SDKS into the top level scope. I knew I had forgotten some part of the change. Thanks for pointing that out.
|
Cygwin calls |
|
I think that this will only cause a problem with cross-compiling on a Linux host for cygwin or if you try to use the gold linker on cygwin. I guess in the |
Simplify the ELF checks based on review comments from Dimitri Gribenko.
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.