[Sema] Move @objc-without-Foundation checking to TypeCheckAttr #31379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
building-on-a-slightly-better-foundation
branch
from
a31e751 to
6c321b9
Compare
CodaFi
approved these changes
Apr 29, 2020
There doesn't seem to be any reason to delay this diagnostic until after type-checking has finished any more, so run it along with the rest of attribute checking.
hamishknight
force-pushed
the
building-on-a-slightly-better-foundation
branch
from
6c321b9 to
beab9f3
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility Debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any reason to delay this diagnostic until after type-checking has finished any more, so run it along with the rest of attribute checking.