[5.3][Diagnostics] Tailored diagnostics for missing member failure when in…

[LucianoPAlmeida]

… literal collection context

cc @xedin

Resolves SR-12672.
Resolves: rdar://problem/62383753

[xedin]

@swift-ci please test

[xedin]

@LucianoPAlmeida There is no need for dyn_cast on the anchor, it's still just an Expr *.

[LucianoPAlmeida]

@LucianoPAlmeida There is no need for dyn_cast on the anchor, it's still just an Expr *.

Ah, I adjust real quick :) I wasn't sure so I looked at other references in the file the ones I've seen were like this

[LucianoPAlmeida]

The Windows build failed with no identified reason ... should we kick it again?

[xedin]

Let's get that get<> removed and I'm going to kick it again.

[xedin]

@swift-ci please smoke test

[xedin]

@swift-ci please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - e2025fdf9e67c6421ec97cf554eb8ba281bcd13c

[xedin]

@swift-ci please smoke test Windows platform

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - e2025fdf9e67c6421ec97cf554eb8ba281bcd13c

[LucianoPAlmeida]

The error on Windows CSDiagnostics.cpp(3432): error C3535: cannot deduce type for 'auto *' from 'swift::constraints::TypedNode' ... so I think we should put the get<> back?

[xedin]

Hm, let me check what is going on here...

[LucianoPAlmeida]

On linux CSDiagnostics.cpp:3432:9: error: variable 'expr' with type 'auto *' has incompatible initializer of type 'TypedNode' (aka 'PointerUnion<const swift::Expr *, const swift::TypeLoc *, const swift::VarDecl *, const swift::Pattern *>

So, I just put the get<>back and replace the cs.getParentExpr with findParentExpr from FailureDiagnostics

[xedin]

Sorry, it's my bad - use castToExpr, looks like only diagnostic refactoring got into 5.3 branch :)

[xedin]

Ok, let's do this!

[xedin]

@swift-ci please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 1a3cadb6ffec877daf94837e3aef9b15166ac5cd

[LucianoPAlmeida]

Any reason for macos and windows not started?

[xedin]

Most likely they are in the queue, let’s give them some time :)

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 1a3cadb6ffec877daf94837e3aef9b15166ac5cd

[LucianoPAlmeida]

Ok I just made sure it builds locally! So I think is fine now :)
@xedin mind kick the tests again?

[xedin]

@swift-ci please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 906fc40321001a1ca003769910017d6678c77f0a

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 906fc40321001a1ca003769910017d6678c77f0a

[xedin]

@LucianoPAlmeida Thank you for fixing this!