Strip Out More TypeLocs #31390
Merged
Strip Out More TypeLocs #31390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
xedin
reviewed
Apr 29, 2020
| @@ -3706,15 +3702,15 @@ class ClosureExpr : public AbstractClosureExpr { | |||
| SourceLoc InLoc; | |||
|
|
|||
| /// The explicitly-specified result type. | |||
| TypeLoc ExplicitResultType; | |||
| TypeExpr *ExplicitResultType; | |||
There was a problem hiding this comment.
The only out of place thing about this is that TypeExpr * type is always a metatype which is not really intended here right? Maybe we should hide the fact that inside closure explicit type is represented via TypeExpr and instead only expose TypeRepr and Type to the outside?
|
@swift-ci test |
|
@swift-ci test Windows |
|
Alright, I've hidden that abstraction. ⛵ |
xedin
reviewed
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TypeLoc from
Type checking for closures is now somewhat simpler.