Skip to content

Frontend tool cleanup #31393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/swift/AST/DiagnosticsFrontend.def
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ ERROR(error_unknown_arg,none,
"unknown argument: '%0'", (StringRef))
ERROR(error_invalid_arg_value,none,
"invalid value '%1' in '%0'", (StringRef, StringRef))
WARNING(warning_type_fingerprints_require_fine_grained_dependencies,none,
"Type fingerprints require fine-grained dependencies", ())
WARNING(warning_cannot_multithread_batch_mode,none,
"ignoring -num-threads argument; cannot multithread batch mode", ())
ERROR(error_unsupported_option_argument,none,
Expand Down
4 changes: 0 additions & 4 deletions include/swift/Basic/LangOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,6 @@ namespace swift {
/// Whether to verify the parsed syntax tree and emit related diagnostics.
bool VerifySyntaxTree = false;

/// Emit the newer, finer-grained swiftdeps file. Eventually will support
/// faster rebuilds.
bool EnableFineGrainedDependencies = true;

/// Instead of hashing tokens inside of NominalType and ExtensionBodies into
/// the interface hash, hash them into per-iterable-decl-context
/// fingerprints. Fine-grained dependency types won't dirty every provides
Expand Down
324 changes: 0 additions & 324 deletions include/swift/Driver/CoarseGrainedDependencyGraph.h

This file was deleted.

10 changes: 0 additions & 10 deletions include/swift/Driver/Compilation.h
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,6 @@ class Compilation {
const bool OnlyOneDependencyFile;

private:
/// Scaffolding to permit experimentation with finer-grained dependencies and
/// faster rebuilds.
const bool EnableFineGrainedDependencies;

/// Is the parser recording token hashes for each type body?
const bool EnableTypeFingerprints;

Expand Down Expand Up @@ -331,8 +327,6 @@ class Compilation {
bool ShowDriverTimeCompilation = false,
std::unique_ptr<UnifiedStatsReporter> Stats = nullptr,
bool OnlyOneDependencyFile = false,
bool EnableFineGrainedDependencies
= LangOptions().EnableFineGrainedDependencies,
bool EnableTypeFingerprints =
LangOptions().EnableTypeFingerprints,
bool VerifyFineGrainedDependencyGraphAfterEveryImport = false,
Expand Down Expand Up @@ -399,10 +393,6 @@ class Compilation {
}
void disableIncrementalBuild(Twine why);

bool getEnableFineGrainedDependencies() const {
return EnableFineGrainedDependencies;
}

bool getEnableTypeFingerprints() const { return EnableTypeFingerprints; }

bool getVerifyFineGrainedDependencyGraphAfterEveryImport() const {
Expand Down
4 changes: 3 additions & 1 deletion include/swift/Driver/FineGrainedDependencyDriverGraph.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "swift/Basic/Debug.h"
#include "swift/Basic/LLVM.h"
#include "swift/Basic/OptionSet.h"
#include "swift/Driver/CoarseGrainedDependencyGraph.h"
#include "swift/Driver/Job.h"
#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/DenseMap.h"
Expand All @@ -38,6 +37,9 @@
// driver.

namespace swift {

class UnifiedStatsReporter;

namespace fine_grained_dependencies {

//==============================================================================
Expand Down
Loading