[CSApply] Fix a case where CSApply produced an invalid DeclRefExpr #31398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if the member is a type reference and build a TypeExpr _before_ checking if the base is a module and building a simple DeclRefExpr.
|
@swift-ci please smoke test |
xedin
approved these changes
Apr 29, 2020
xedin
reviewed
Apr 29, 2020
|
|
||
| // CHECK: declref_expr type='module<SomeModule>' | ||
| // CHECK-NEXT: type_expr type='Data.Type' | ||
| let type = SomeModule.Data.self |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re-writing an
UnresolvedDotExprto a resolved member reference, check if the member is a type reference and build aTypeExprbefore checking if the base is a module and building a simpleDeclRefExpr. Otherwise, CSApply could produce invalidDeclRefExprs for a type reference, which will crash later on in SILGen.Resolves: rdar://problem/61450069