[5.3][ConstraintSystem] Don't attempt property wrapper fixes for key path … #31418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dynamic member lookup If this is an attempt to fetch members through key path dynamic member lookup let's not try to apply any property wrapper related fixes because modifying base type would not change the result. Resolves: [SR-12520](https://bugs.swift.org/browse/SR-12520) Resolves: rdar://problem/61911108 (cherry picked from commit 6bdd534)
xedin
changed the title
|
@swift-ci please test |
|
@swift-ci please smoke test Windows platform |
DougGregor
approved these changes
Apr 29, 2020
|
Windows failure is unrelated - |
|
@compnerd Can you look at the Windows node, it's running out of space? https://ci-external.swift.org/computer/windows-vs2019-03/ |
|
Cleaned up the host, thanks for the notification @shahmishal |
|
@swift-ci please smoke test Windows platform |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dynamic member lookup
If this is an attempt to fetch members through key path dynamic member lookup
let's not try to apply any property wrapper related fixes because modifying
base type would not change the result.
Reviewed By: @hborla
Resolves: SR-12520
Resolves: rdar://problem/61911108
(cherry picked from commit 6bdd534)