Skip to content

[5.3][Darwin] Import all overlay shims with @_implementationOnly #31428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

[5.3][Darwin] Import all overlay shims with @_implementationOnly #31428

merged 1 commit into from
Apr 30, 2020

Conversation

lorentey
Copy link
Member

This removes these imports from the generated Swift modules, and also makes sure shims aren't used in any inlinable code.

C.f. #28918

rdar://62626788

(cherry picked from commit 037e7f9)

@lorentey lorentey added the r5.3 label Apr 30, 2020
@lorentey lorentey requested a review from kylemacomber April 30, 2020 00:58
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 2d10a3d into swiftlang:release/5.3 Apr 30, 2020
@lorentey lorentey deleted the private-shims-5.3 branch April 30, 2020 17:53
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylemacomber kylemacomber kylemacomber approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentey @kylemacomber @AnthonyLatsis