[IDE][SourceKit] Support escaped identifiers for the syntactic rename and related idents requests. #31431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathawes
force-pushed
the
rename-with-backticks
branch
from
0e48aec to
33cbf7a
Compare
|
@swift-ci please test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
Build failed |
|
Build failed |
nathawes
force-pushed
the
rename-with-backticks
branch
from
33cbf7a to
45d5bfa
Compare
|
@swift-ci please test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
Build failed |
|
Build failed |
nathawes
force-pushed
the
rename-with-backticks
branch
from
45d5bfa to
a797038
Compare
… and related idents requests. Resolves rdar://problem/46409010 Resolves rdar://problem/48256383
nathawes
force-pushed
the
rename-with-backticks
branch
from
a797038 to
0f8619b
Compare
|
@swift-ci please test |
|
@swift-ci Please Build Toolchain macOS Platform |
nathawes
changed the title
|
Build failed |
|
Build failed |
benlangmuir
reviewed
May 4, 2020
benlangmuir
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both would previously not account for the extra two backticks in their name, e.g. giving
[`fo]o`rather than[`foo`].This updates their ranges to include the backticks, and for syntactic rename, to account for them when comparing base names and argument labels with expected values. It also updates Swift -> ObjC name translation to account for them too.
Resolves rdar://problem/46409010
Resolves rdar://problem/48256383