Sema: Fix crash with stored property that has on-demand 'modify' accessor [5.3] #31434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssor If a stored property has observers, the 'modify' coroutine body takes a special form which directly yields the underlying storage and calls the 'didSet' and/or 'willSet' accessors. However, if a property is 'dynamic', the 'modify' coroutine is synthesized on-demand and it's SIL is serialized. It cannot reference the 'didSet' or 'willSet' accessors, since they are private. Furthermore, an on-demand accessor must also work if the property is overridden in a subclass. So in this case, fall back to the more general 'modify' synthesis code, which just calls the getter followed by the setter. Fixes <rdar://problem/62339808>.
|
@swift-ci Please test |
DougGregor
approved these changes
Apr 30, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a stored property has observers, the 'modify' coroutine body takes a
special form which directly yields the underlying storage and calls the
'didSet' and/or 'willSet' accessors.
However, if a property is 'dynamic', the 'modify' coroutine is synthesized
on-demand and it's SIL is serialized. It cannot reference the 'didSet'
or 'willSet' accessors, since they are private. Furthermore, an on-demand
accessor must also work if the property is overridden in a subclass.
So in this case, fall back to the more general 'modify' synthesis code,
which just calls the getter followed by the setter.
Fixes rdar://problem/62339808.