build: shuffle library order #31459
Merged
build: shuffle library order #31459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELF is sensitive to library ordering. Ensure that `swiftClangImporter` comes after `swiftAST` as `swiftAST` has grown a dependency on `swiftClangImporter`. Adding this properly using `target_link_libraries` will cause a cyclic dependency so add this reordering here.
|
Can confirm that I used to get a linker error, but with this patch applied tests now appear to build properly. Thank you @compnerd |
|
My pleasure @saeta! |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELF is sensitive to library ordering. Ensure that
swiftClangImportercomes after
swiftASTasswiftASThas grown a dependency onswiftClangImporter. Adding this properly usingtarget_link_librarieswill cause a cyclic dependency so add thisreordering here.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.