[IDE] Loosen assertion check in IDE/SyntaxModelWalker #31465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
We were asserting that the attribute range recorded in the AST started at the same location as the fist unconsumed SyntaxNode in the file. This should be true in most cases, but isn't for mispelled attributes, corrected in the AST but not recognised or present in the list of SyntaxNodes. E.g. @Availability(...) comes through as if @available(...) was specified, but there's no SyntaxNode for it because we don't highlight invalid attributes (to indicate they're invalid). Resolves rdar://problem/62201594 Resolves https://bugs.swift.org/browse/SR-12500
nathawes
force-pushed
the
doc-info-availability-catalyst
branch
from
b68199b to
deecb58
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
rintaro
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were asserting that the attribute range recorded in the AST started at the same location as the fist unconsumed SyntaxNode in the file. This should be true in most cases, but isn't for misspelled attributes, corrected in the AST but not recognized or present in the list of SyntaxNodes. E.g.
@availability(...)comes through as if@available(...)was specified, but there's no SyntaxNode for it because we don't highlight invalid attributes (to indicate they're invalid).Resolves rdar://problem/62201594
Resolves https://bugs.swift.org/browse/SR-12500