[5.3] Diagnose exclusivity in the presence of coroutines. #31483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
changed the title
|
@swift-ci test |
theblixguy
reviewed
May 1, 2020
Potentially source breaking: SR-11700 Diagnose exclusivity violations with Dictionary.subscript._modify: Exclusivity violations within code that computes the `default` argument during Dictionary access are now diagnosed. ```swift struct Container { static let defaultKey = 0 var dictionary = [defaultKey:0] mutating func incrementValue(at key: Int) { dictionary[key, default: dictionary[Container.defaultKey]!] += 1 } } error: overlapping accesses to 'self.dictionary', but modification requires exclusive access; consider copying to a local variable dictionary[key, default: dictionary[Container.defaultKey]!] += 1 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ note: conflicting access is here dictionary[key, default: dictionary[Container.defaultKey]!] += 1 ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ ``` This reworks the logic so that four problems end up being fixed: Fixes three problems related to coroutines: (1) DiagnoseStaticExclusivity must consider begin_apply as a user of accessed variables. This was an undefined behavior hole in the diagnostics. (2) AccessedSummaryAnalysis should consider begin_apply as a user of accessed arguments. This does not show up in practice because coroutines don't capture things. (3) AccessedSummaryAnalysis must consider begin_apply a valid user of noescape closures. And fixes one problem related to resilience: (4) AccessedSummaryAnalysis must conservatively consider arguments to external functions. Fixes <rdar://problem/56378713> Investigate why AccessSummaryAnalysis is crashing (cherry picked from commit 6823b10)
|
@swift-ci test |
|
Build failed |
|
@swift-ci test |
|
@shahmishal I'm not sure why OS X testing won't kick off |
|
Build failed |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially source breaking: SR-11700 Diagnose exclusivity violations
with Dictionary.subscript._modify:
Exclusivity violations within code that computes the
defaultargument during Dictionary access are now diagnosed.
This reworks the logic so that four problems end up being fixed:
Fixes three problems related to coroutines:
(1) DiagnoseStaticExclusivity must consider begin_apply as a user of accessed variables. This was an undefined behavior hole in the diagnostics.
(2) AccessedSummaryAnalysis should consider begin_apply as a user of accessed arguments. This does not show up in practice because coroutines don't capture things.
(3) AccessedSummaryAnalysis must consider begin_apply a valid user of
noescape closures.
And fixes one problem related to resilience:
(4) AccessedSummaryAnalysis must conservatively consider arguments to external functions.
Fixes rdar://problem/56378713 Investigate why AccessSummaryAnalysis is crashing
(cherry picked from commit 6823b10)