[AutoDiff] NFC: prettify commutative diagrams. #31525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make commutative diagrams pretty using Unicode box characters. Use lowercase letters for arrow names.
|
@swift-ci Please smoke test |
rxwei
approved these changes
May 4, 2020
dan-zheng
commented
May 4, 2020
| // its derivative type. This is the expected lowered derivative type, | ||
| // preserving SIL typing invariants. | ||
| // | ||
| // Always use (AD) to compute lowered derivative function types. | ||
| // Always use (ad) to compute lowered derivative function types. |
There was a problem hiding this comment.
Nice autodiff pun: Always use (ad)
|
Linux CI seems to have flaked. |
|
@swift-ci Please smoke test Linux |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Jun 3, 2020
Make commutative diagrams pretty using Unicode box characters. Use lowercase letters for arrow names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make commutative diagrams pretty using Unicode box characters.
Use lowercase letters for arrow names.
Rationale: if we're going to draw a diagram, we might as well make it as pretty as possible. Maintenance shouldn't be an issue.
Unicode resource: https://antofthy.gitlab.io/info/data/utf8-demo.txt
Inspired by: https://twitter.com/lexi_lambda/status/1255988716390297601