[5.3][SourceKit] Report macCatalyst availability as macCatalyst rather than iOS #31536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n iOS Resolves rdar://problem/60918688
|
@swift-ci please test |
|
@swift-ci please nominate |
akyrtzi
approved these changes
May 6, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #31466 for 5.3.
Explanation:
SourceKit's doc-info request was incorrectly reporting the platform of
@available(macCatalyst, ...)attributes assource.availability.platform.iosrather thansource.availability.platform.maccatalyst.Scope of issue: Only impacts sourcekitd's doc-info request. Other sourcekitd requests and the compiler are unaffected.
Origination: Has been an issue since explicit macCatalyst availability attribute support was added.
Risk: Low. It's a single line change and only impacts SourceKit's doc-info request.
Testing: Added a regression test for this case and all existing tests pass.
Reviewer: Rintaro Ishizaki (@rintaro) on the master branch PR
Resolves rdar://problem/60918688