[Function builders] Add for...in loop support via buildArray(). #31543
+204
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Extend function builders with support for for..in loops, such as
for person in contacts {
"Hello \(person.name)"
}
The loop will be (eagerly) executed and all results will be collected
into an array. That array will be passed to a function `buildArray` to
produce the result from the loop. Specifically, the above will be
translated to the following when used with a function builder type
named `FunctionBuilder`,, where all $ names are introduced by the
compiler and are not user-visible:
let $a1: $T1
var $a2: [$T2] = []
for person in contacts {
let $a3: $T3
let $a4 = FunctionBuilder.buildExpression("Hello \(person.name)")
$a3 = FunctionBuilder.buildBlock($a4)
$a2.append($3)
}
$a1 = FunctionBuilder.buildArray($a2)
where `$a1` is the result of the for-each loop.
DougGregor
force-pushed
the
function-builders-buildarray
branch
from
4592a31 to
19e234f
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test |
|
@swift-ci smoke test macOS |
1 similar comment
|
@swift-ci smoke test macOS |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
xedin
approved these changes
May 5, 2020
| // Form an initialization of the array to an empty array literal. | ||
| Expr *arrayInitExpr = ArrayExpr::create(ctx, loc, { }, { }, loc); | ||
| cs->setContextualType( | ||
| arrayInitExpr, TypeLoc::withoutLoc(arrayType), CTP_CannotFail); |
There was a problem hiding this comment.
@CodaFi It seems like this is yet another place where TypeLoc is not really used, usually it's just a Type or TypeRepr I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend function builders with support for for..in loops, such as
The loop will be (eagerly) executed and all results will be collected
into an array. That array will be passed to a function
buildArraytoproduce the result from the loop. Specifically, the above will be
translated to the following when used with a function builder type
named
FunctionBuilder,, where all $ names are introduced by thecompiler and are not user-visible:
where
$a1is the result of the for-each loop.