Add IgnoreContextualType fix on Keypath -> Function type mismatch. #31563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In If there's a way to provide enough context at the failure site so that the correct error message is emitted, I'd be curious to hear it. |
|
@swift-ci test |
xedin
reviewed
May 5, 2020
|
Build failed |
artemcm
force-pushed
the
TypeCheckKeypathAsClosure
branch
from
b008d12 to
2f9891b
Compare
artemcm
changed the title
artemcm
force-pushed
the
TypeCheckKeypathAsClosure
branch
from
2f9891b to
4b6165b
Compare
|
@swift-ci test |
xedin
reviewed
May 6, 2020
artemcm
force-pushed
the
TypeCheckKeypathAsClosure
branch
from
4b6165b to
e6901c5
Compare
artemcm
force-pushed
the
TypeCheckKeypathAsClosure
branch
from
e6901c5 to
3ac69a2
Compare
xedin
approved these changes
May 7, 2020
When simplifying a keypath constraint with a function type binding, single-parameter functions have the parameter type and the return type matched against the keypath root and value; whereas multiple-parameter functions cause an ambiguous failure (in `simplifyKeyPathConstraint`). Resolves rdar://problem/57930643
artemcm
force-pushed
the
TypeCheckKeypathAsClosure
branch
from
3ac69a2 to
7aed042
Compare
|
@swift-ci test |
|
Build failed |
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
May 8, 2020
…match. Cherry-pick swiftlang#31563, originally reviewed by @xedin. When simplifying a keypath constraint with a function type binding, single-parameter functions have the parameter type and the return type matched against the keypath root and value; whereas multiple-parameter functions cause an ambiguous failure (in `simplifyKeyPathConstraint`). Resolves rdar://problem/57930643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When simplifying a KeyPath constraint with a KeyPath type variable bound to a function type, single-parameter function types have the parameter type and the return type matched against the KeyPath root and value types; whereas multiple-parameter functions cause an ambiguous failure (in
simplifyKeyPathConstraint).Resolves rdar://problem/57930643