[5.3][CodeCompletion] Dont mark type mismatching items 'not recommended' #31566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
func foo() {}
let a: Int = #^HERE^#
Previously, we marked 'foo()' as 'NotRecommented' because 'Void' doesn't
have any member hence it cannot be 'Int'. But it wass confusing with
'deprecated'.
Now that we output 'typerelation' which is 'invalid' in this case. So clients
can deprioritize results, or even filter them out.
rdar://problem/57726512
(cherry picked from commit e9c438c)
|
@swift-ci Please test |
akyrtzi
approved these changes
May 5, 2020
|
@swift-ci Please nominate |
|
Build failed |
|
@swift-ci Please test Linux |
|
Build failed |
|
Linux failure is unrelated: |
rintaro
deleted the
5.3-sourcekit-completion-invalidtyperelation-rdar57726512
branch
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #31474 into
release/5.3Voidtype as 'NotRecommented' in non-Void context becauseVoiddoesn't have any member hence it cannot be 'Int'. But it was confusing with "deprecated". Now that we output 'typerelation' which isinvalidin this case. So clients can deprioritize results, or even filter them out.