[ConstraintSystem] Temporary revert 84a3db45db96 as a workaround for rdar://problem/62842651
#31569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
reviewed
May 5, 2020
| @@ -0,0 +1,12 @@ | |||
| // RUN: %target-swift-frontend -emit-sil -verify %s | %FileCheck %s | |||
There was a problem hiding this comment.
Shouldn't this test be in test/SILGen then? (And it can use -emit-silgen instead of -emit-sil, which also runs mandatory passes)
There was a problem hiding this comment.
This is a problem where type-checker infers types incorrectly I just could think of an easier and more robust way to verify it in test-case then check emitted SIL.
There was a problem hiding this comment.
I didn't want to match against constraint system output because that would just become a constant pain to maintain if anything changes with locators and/or type variables.
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert
84a3db45db96and add a test to make sure we generate correct SIL forrdar://problem/62842651Resolves: rdar://problem/62842651