[utils/build-parser-lib] Fixes for building the parser library #31577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akyrtzi
commented
May 6, 2020
akyrtzi
commented
- Need to symlink 'swift' into 'llvm-project' since we are doing a unified configure with 'swift' as an external project.
- Need to set "-DLLVM_ENABLE_LIBEDIT=FALSE" to get iOS builds working again
akyrtzi
force-pushed
the
build-parser-lib-fixes
branch
from
e8b6165 to
5612346
Compare
|
I had tried symlinking swift into llvm-project (and symlinked llvm in swift-project) and there were still errors. I don't understand this codebase though so I can't help much 😅 |
* Need to symlink 'swift' into 'llvm-project' since we are doing a unified configure with 'swift' as an external project. * Need to set "-DLLVM_ENABLE_LIBEDIT=FALSE" to get iOS builds working again
akyrtzi
force-pushed
the
build-parser-lib-fixes
branch
from
5612346 to
7600043
Compare
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.