Sema: Only run extension binding once #31605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line As part of eliminating cascading dependencies, we need to make sure to capture any dependencies discovered during SILGen and IRGen. This is a little bit tricky because we exit early in various places in the pipeline, so we want to do it after performCompileStepsPostSema() returns, but we can't do it too late, because the ASTContext might already have been deallocated. So emit the dependencies manually before freeing the ASTContext if we decide to do that, or just do it before returning from performCompile() using a SWIFT_DEFER otherwise. This should have no observable effect until we start recording dependencies for lookups done on behalf of declarations in secondary files.
|
LLVM change: swiftlang/llvm-project#1183 |
There's no need to walk all imports of all source files, and bind the extensions defined therein. The only time that a non-main module contains source files is when using -enable-source-import, and we can just explicitly call bindExtensions() in the right place.
Doing it here is unnecessary anyway, because we've already performed extension binding by this point.
slavapestov
force-pushed
the
only-bind-extensions-once
branch
from
2e2c0e5 to
4c797cc
Compare
|
swiftlang/llvm-project#1183 |
|
swiftlang/llvm-project#1183 |
|
swiftlang/llvm-project#1183 |
1 similar comment
|
swiftlang/llvm-project#1183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to walk all imports of all source files, and bind the
extensions defined therein. The only time that a non-main module
contains source files is when using -enable-source-import, and we
can just explicitly call bindExtensions() in the right place.