[5.3][ConstraintSystem] Always verify computed/resolved pattern types befo… #31614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re use While trying to infer type for pattern always take result of `getTypeForPattern` and `resolveTypeInExpressionContext` with a grain of salt because both of these methods produce empty type if type as-written or one of the sub-pattern types is incorrect. Resolves: rdar://problem/60534522 (cherry picked from commit f22ca72)
|
@swift-ci please test |
DougGregor
approved these changes
May 7, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re use
Cherry-pick of #31604
Explanation: While trying to infer type for pattern always take result of
getTypeForPatternandresolveTypeInExpressionContextwitha grain of salt because both of these methods produce empty type
if type as-written or one of the sub-pattern types is incorrect.
Scope: Type-checker stability improvements in constraint generation of patterns
Resolves: rdar://problem/60534522
Risk: Low
Testing: Unfortunately I couldn't find a test-case for this. These changes introduce multiple
null checks.
Reviewer: @DougGregor
Resolves: rdar://problem/60534522
(cherry picked from commit f22ca72)