Skip to content

[Lexer] Add test case for erroneous hex number literal #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 23, 2016

What's in this pull request?

Follow up on #3124 and #3132 .

CC: @jckarter

var fl_t: Float = 0x1.p // expected-error {{value of type 'Int' has no member 'p'}}
var fl_u: Float = 0x1.p2 // expected-error {{value of type 'Int' has no member 'p2'}}
var fl_v: Float = 0x1.p+ // expected-error {{'+' is not a postfix unary operator}}
var fl_w: Float = 0x1.p+2 // expected-error {{value of type 'Int' has no member 'p'}}

Added in float literal test cases. Is it OK?


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

@rintaro rintaro force-pushed the hexnumber-literal-testcase branch from 4328ac1 to 7f999d6 Compare June 23, 2016 12:23
@rintaro rintaro force-pushed the hexnumber-literal-testcase branch from 7f999d6 to 776c8cb Compare June 23, 2016 12:32
@lattner
Copy link
Contributor

lattner commented Jun 23, 2016

Nice.

@swift-ci please test and merge

@jckarter
Copy link
Contributor

LGTM, thanks @rintaro !

@rintaro
Copy link
Member Author

rintaro commented Jun 24, 2016

https://ci.swift.org/job/swift-PR-merge/506/
All tests are passed, but CI failed to merge. I'm going to merge this manually.

@rintaro rintaro merged commit 57df1fa into swiftlang:master Jun 24, 2016
@lattner
Copy link
Contributor

lattner commented Jun 24, 2016

Thanks!

@rintaro rintaro deleted the hexnumber-literal-testcase branch June 27, 2016 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants