Skip to content

[5.3][SymbolGraph] Use identifier for type name fragments #31628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged

[5.3][SymbolGraph] Use identifier for type name fragments #31628

merged 1 commit into from
May 8, 2020

Conversation

bitjammer
Copy link
Contributor

In the cases where we specialize the presentation of type declarations in a
subheading or navigator setting, make sure to use the identifier fragment
kind instead of typeIdentifier to keep it consistent with the normal or
"full" setting.

rdar://62953144

In the cases where we specialize the presentation of type declarations in a
subheading or navigator setting, make sure to use the `identifier` fragment
kind instead of `typeIdentifier` to keep it consistent with the normal or
"full" setting.

rdar://62953144
@bitjammer bitjammer added the r5.3 label May 7, 2020
@bitjammer bitjammer requested a review from jackhl May 7, 2020 18:14
@bitjammer bitjammer requested a review from a team as a code owner May 7, 2020 18:14
@bitjammer
Copy link
Contributor Author

@swift-ci Please test

Copy link

@jackhl jackhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; discussed with @bitjammer offline as well.

@bitjammer bitjammer merged commit 15956e4 into swiftlang:release/5.3 May 8, 2020
@bitjammer bitjammer deleted the acgarland/rdar-62953144-use-identifier-for-type-names-5.3 branch May 8, 2020 16:46
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants