[SourceKit] Share common object printer code #3163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 task
| @@ -177,6 +179,83 @@ static inline sourcekitd_variant_t makeUIDVariant(sourcekitd_uid_t value) { | |||
| return {{ 0, (uintptr_t)value, SOURCEKITD_VARIANT_TYPE_UID }}; | |||
| } | |||
|
|
|||
| template <typename VisitorImplClass, typename VisitedType> | |||
| class RequestResponsePrinterBase { | |||
There was a problem hiding this comment.
I recommend to split RequestResponsePrinterBase to its own header. Internal.h is getting large.
This is an attempt to clean up code duplication around printing SourceKit request and response objects.
briancroom
force-pushed
the
sourcekit-shared-object-printer
branch
from
c4497dc to
5a30003
Compare
|
I finally got it now! Sorry you for making you spell it out in such detail 😬 I don't think I've encountered quite this pattern before. |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
I thought it would make sense to open a new PR for a subset of the changes being discussed in #3026.
This is my attempt at implementing @akyrtzi's suggestion here. I didn't see how it would be possible to do it exactly as proposed, since the
SKDObjectPrinterBaseclass needs access to thevisitmethod to dispatch based on the type of arbitrary elements in a dictionary or array. I used a slightly different structure here which seemed to make sense, however the previous design of the classesSKDObjectVisitorandSKDObjectPrinterclasses seemed confusing to me to begin with, so it's quite possible that some original design goals haven't been preserved with my changes.I also noticed that the code duplication being discussed in relation to the InProc additions in #3026 already existed with the XPC
SKDObjectPrinterand theVariantPrinterclasses which I am addressing here.Related bug number: (SR-1639)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
This is an attempt to clean up code duplication around printing SourceKit
request and response objects.