[CodeCompletion] Annotated result type name #31637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
ide-completion-annotatedtypename-rdar62617558
branch
from
2696d9a to
14b7890
Compare
Introduced 'TypeAnnotationBegin' chunk kind for grouping the result type name chunks. rdar://problem/62617558
rintaro
force-pushed
the
ide-completion-annotatedtypename-rdar62617558
branch
from
14b7890 to
7086ffb
Compare
|
@swift-ci Please test |
rintaro
changed the title
akyrtzi
reviewed
May 12, 2020
| @@ -1236,6 +1236,7 @@ void SwiftLangSupport::codeCompleteOpen( | |||
| typeContextKind = completionCtx.typeContextKind; | |||
| mayUseImplicitMemberExpr = completionCtx.MayUseImplicitMemberExpr; | |||
| consumer.setReusingASTContext(completionCtx.ReusingASTContext); | |||
| consumer.setAnnotatedTypename(completionCtx.getAnnnoateResult()); | |||
benlangmuir
approved these changes
May 12, 2020
| @@ -3990,7 +4074,7 @@ class CompletionLookup final : public swift::VisibleDeclConsumer { | |||
| builder.setLiteralKind(kind); | |||
|
|
|||
| consumer(builder); | |||
| addTypeRelationFromProtocol(builder, kind, defaultTypeName); | |||
| addTypeRelationFromProtocol(builder, kind); | |||
There was a problem hiding this comment.
defaultTypeName is now unused, so you can remove it from the lambda and the callsites. This applies to both the addFromProto lambdas in this patch.
|
@swift-ci Please smoke test |
akyrtzi
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced 'TypeAnnotationBegin' chunk kind for grouping the result type name chunks.
rdar://problem/62617558