[NFC] AST: Relocate some conformance lookup client methods from DeclContext to IterableDeclContext #31645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
commented
May 8, 2020
| } | ||
| SmallVector<Requirement, 4> FilteredRequirements; | ||
| filterGenericRequirements( | ||
| ConformanceExtension->getGenericRequirements(), |
There was a problem hiding this comment.
This is simply getting rid of redundant (and now ambiguous) calls to getAsGenericContext()
|
@swift-ci please smoke test |
AnthonyLatsis
changed the title
AnthonyLatsis
force-pushed
the
relocate-to-iterabledc
branch
from
96c14f5 to
bfe25fa
Compare
|
@swift-ci please smoke test |
|
@CodaFi Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the set of declaration nodes we can call these methods on by moving
getLocalProtocols,getLocalConformancesandtakeConformanceDiagnosticstoIterableDeclContext, and addingIterableDeclContext::getAsGenericContext()to make up for the casting complications.